musiclink/docs/reviews/cli-entrypoints.md

Code Review: CLI Entrypoints

Scope

• cmd/musiclink/main.go
• cmd/smoketest/main.go

Findings

✅ Strengths

• Clean startup flow: load config → init handler → start Matrix bot → graceful shutdown on SIGINT/SIGTERM.
• Smoketest now includes retry/backoff for API calls and clear output.

⚠️ Issues / Opportunities

1. Smoketest depends on external API availability
   • Even with retries, the smoketest relies on idonthavespotify uptime and network access.
   • Consider documenting that it is a live integration check and may fail offline.

Notes

• Matrix-only runtime is explicit; no hidden mode toggles or legacy paths.