musiclink/docs/reviews/issues.md

Code Review Issues (Aggregated)

CLI Entrypoints

1. Smoke test hard-fails on external API issues — Deferred
   • No retries/backoff; relies on idonthavespotify uptime.

Bot Transport Layers

2. Matrix send loop has no shutdown drain — Deferred

   • Queued responses may be lost on shutdown.

3. State store cleanup only on message processing — Deferred

   • Stale dedupe entries can persist during idle periods.

Message Handling & Link Detection

4. Detector ignores formatted links — Deferred

   • No parsing for Markdown/HTML link formats.

5. Resolver only processes first link — Deferred

   • Multiple links in one message are ignored beyond the first.

6. Service mapping lacks Qobuz support — Deferred

   • Enum exists but no detection/formatting.