musiclink/docs/reviews/issues-status.md

Code Review Issues Status

CLI Entrypoints

1. Matterbridge close on fatal path — Dropped

   • Matterbridge runtime removed; no longer applicable.

2. Smoke test hard-fails on external API issues — Defer

   • Acceptable for manual smoketest; revisit if automated CI uses it.

Bot Transport Layers

3. Matterbridge message channel drop without metrics — Dropped

   • Matterbridge runtime removed; no longer applicable.

4. Matrix send queue drops without marking dedupe — Fix

   • Should mark processed on drop or add retry/queue sizing safeguards.

5. Matrix encrypted room handling is partial — Fix

   • Add startup check for encryption state or guard until encryption state known.

6. Matrix send loop has no shutdown drain — Defer

   • Low impact; log queue length or add best-effort drain later.

7. State store cleanup only on message processing — Defer

   • Low impact; consider periodic cleanup task if store grows.

Message Handling & Link Detection

8. Detector misses common URL variants — Fix

   • Expand regex for common variants (spoti.fi, Apple Music track URLs, etc.).

9. Detector ignores formatted links — Defer

   • Requires HTML/Markdown parsing; not urgent for plain-text traffic.

10. Resolver only processes first link — Defer

    • Clarify behavior or implement multi-link responses later.

11. API error handling omits response body — Fix

    • Capture response body (bounded) on non-200 responses for debugging.

12. Service mapping lacks Qobuz support — Defer

    • Decide whether to add Qobuz support or remove enum later.