Nim's varargs doesn't consume the last positional argument when there's
a trailing parameter with a default value. This caused calls like
`runGit("fetch", "origin")` to be parsed as:
- args = ["fetch"]
- workDir = "origin"
Instead of the intended:
- args = ["fetch", "origin"]
- workDir = ""
Fixed by changing from varargs to openArray, which requires explicit
array syntax at call sites: `runGit(["fetch", "origin"])`.
Also includes P2 bug fixes:
- Start heartbeat before state transition (skills-qekj)
- Reject symlinks when reading context file (skills-16zf)
- Case-insensitive conflict detection (skills-n3qp)
Smoke tested: spawn, status, start, show, cancel all work.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
worker.nim:
- Start heartbeat before state transition in start command
(prevents WORKING state without heartbeat if startup fails)
context.nim:
- Reject symlinks when reading context file (security)
(prevents reading arbitrary files via symlinked .worker-ctx.json)
git.nim:
- Use case-insensitive conflict detection in rebase/merge
(toLowerAscii instead of checking "CONFLICT" and "conflict" separately)
Closes: skills-qekj, skills-16zf, skills-n3qp
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
types.nim:
- Remove unused constants: BusJsonlPath, BlobsDir, WorkersDir
worker.nim:
- Remove unused 'by' and 'comment' parameters from approve()
Note: skills-5ax (unused imports in db.nim) no longer applies -
strutils is used for toHex in genOid fallback path.
Closes: skills-t9ub, skills-5ax, skills-fdu, skills-ghlb
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add branchName() and worktreePath() helpers for consistent path generation
- Add msToTime() for epoch ms to Time conversion (8 occurrences consolidated)
- Add validateTaskId() for CLI input validation (prevents path traversal)
- Add optString/optInt64 helpers for nullable DB values
- Add withTransaction template for automatic rollback on error
Closes: skills-lzh2, skills-3d9o, skills-5x2o, skills-qiq0, skills-73yu, skills-vuj2
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- genOid: use std/sysrand for cryptographic randomness instead of rand()
- HeartbeatThread: change from ptr with manual alloc/dealloc to ref object
- Add error handling for DB open in heartbeat thread
- Remove unused globalChannel and times import
Closes: skills-0wk, skills-bk7x, skills-69sz, skills-ib9u, skills-kvdl, skills-n6zf
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
