dan/skills
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix(playwright-visit): use domcontentloaded instead of networkidle

Browse source 
networkidle times out on heavy sites like nytimes.com.
domcontentloaded + wait parameter is more reliable.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
dan 2025-12-29 01:15:34 -05:00
parent 076588a34d
commit ad15afecf0
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
skills/playwright-visit/scripts/visit.py
View file

@ -23,7 +23,7 @@ def cmd_screenshot(args):
with sync_playwright() as p:
browser = get_browser(p)
page = browser.new_page()
page.goto(args.url, wait_until="networkidle")
page.goto(args.url, wait_until="domcontentloaded")
page.wait_for_timeout(args.wait)
page.screenshot(path=args.output, full_page=args.full_page)
browser.close()
@ -35,7 +35,7 @@ def cmd_text(args):
with sync_playwright() as p:
browser = get_browser(p)
page = browser.new_page()
page.goto(args.url, wait_until="networkidle")
page.goto(args.url, wait_until="domcontentloaded")
page.wait_for_timeout(args.wait)
text = page.inner_text("body")
browser.close()
@ -47,7 +47,7 @@ def cmd_html(args):
with sync_playwright() as p:
browser = get_browser(p)
page = browser.new_page()
page.goto(args.url, wait_until="networkidle")
page.goto(args.url, wait_until="domcontentloaded")
page.wait_for_timeout(args.wait)
html = page.content()
browser.close()
@ -59,7 +59,7 @@ def cmd_pdf(args):
with sync_playwright() as p:
browser = get_browser(p)
page = browser.new_page()
page.goto(args.url, wait_until="networkidle")
page.goto(args.url, wait_until="domcontentloaded")
page.wait_for_timeout(args.wait)
page.pdf(path=args.output)
browser.close()