dan/skills
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

bd sync: 2026-01-10 20:41:42

Browse source
This commit is contained in:
dan 2026-01-10 20:41:42 -08:00
parent 32fc21b089
commit 7e368a2cde
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.beads/issues.jsonl
View file

@ -133,7 +133,7 @@
{"id":"skills-fvc.6","title":"Summarize review findings","description":"Create summary of code review findings for {{target}}:\n\n- Total findings by severity (HIGH/MED/LOW)\n- Top issues by category\n- Recommendations for immediate action\n- Technical debt assessment\n\nThis summary will become the squash digest.","status":"closed","priority":2,"issue_type":"task","created_at":"2025-12-25T10:16:34.590409022-05:00","updated_at":"2025-12-26T23:22:41.459279583-05:00","closed_at":"2025-12-26T23:22:41.459279583-05:00","close_reason":"Replaced by /code-review skill","dependencies":[{"issue_id":"skills-fvc.6","depends_on_id":"skills-fvc","type":"parent-child","created_at":"2025-12-25T10:16:34.591813242-05:00","created_by":"daemon"}]}
{"id":"skills-fvc.7","title":"Explore {{target}} for review candidates","description":"If {{target}} is a directory, explore to find files worth reviewing.\n\n## For Bloat Lens\n- Find files over 300 lines (warning) or 500 lines (critical)\n- Find functions over 50 lines\n- Identify files with multiple responsibilities\n\n## For Other Lenses\n- Sample representative files from different modules\n- Prioritize high-traffic code over rarely-used\n\n## Output\nList of specific files to run through lenses, prioritized by likely issues.\n\nSkip if {{target}} is already a specific file.","status":"closed","priority":2,"issue_type":"task","created_at":"2025-12-26T01:49:18.377427063-05:00","updated_at":"2025-12-26T23:22:41.465019112-05:00","closed_at":"2025-12-26T23:22:41.465019112-05:00","close_reason":"Replaced by /code-review skill","dependencies":[{"issue_id":"skills-fvc.7","depends_on_id":"skills-fvc","type":"parent-child","created_at":"2025-12-26T01:49:18.383625871-05:00","created_by":"daemon"}]}
{"id":"skills-fvx","title":"use-skills.sh: stderr from nix build corrupts symlinks when repo is dirty","description":"In use-skills.sh, the line:\n\n```bash\nout=$(nix build --print-out-paths --no-link \"${SKILLS_REPO}#${skill}\" 2\u003e\u00261) || {\n```\n\nThe `2\u003e\u00261` merges stderr into stdout. When the skills repo is dirty, nix emits a warning to stderr which gets captured into $out and used as the symlink target.\n\nResult: symlinks like:\n```\norch -\u003e warning: Git tree '/home/dan/proj/skills' is dirty\n/nix/store/j952hgxixifscafb42vmw9vgdphi1djs-ai-skill-orch\n```\n\nFix: redirect stderr to /dev/null or filter it out before creating symlink.","status":"closed","priority":1,"issue_type":"bug","created_at":"2025-12-14T11:54:03.06502295-08:00","updated_at":"2025-12-14T11:59:25.472044754-08:00","closed_at":"2025-12-14T11:59:25.472044754-08:00"}
{"id":"skills-g2wa","title":"Architectural cleanup: error handling, validation, utilities","description":"# Architectural Cleanup Epic\n\nCode review of worker CLI scaffold revealed 44 issues that cluster into 5 systemic patterns.\nRather than fixing individually, address the underlying architecture.\n\n## Pattern Analysis\n\n| Pattern | Issues | % |\n|---------|--------|---|\n| Error handling gaps | 11 | 25% |\n| DRY / missing utilities | 12 | 27% |\n| Input validation missing | 4 | 9% |\n| Dead code | 5 | 11% |\n| Type safety | 3 | 7% |\n\n## Recommended Approach\n\n### 1. Create utils.nim module\nConsolidates 12 extraction issues:\n- branchName(taskId): string\n- worktreePath(taskId): string \n- msToUnix(ms: int64): int64\n- optField[T](row, idx): Option[T]\n- withTransaction template\n- validateTaskId(id): string\n\n### 2. Define error handling strategy\nTemplate for 11 error issues:\n- Wrap boundary operations (file I/O, git, DB) with context\n- Consistent exception types or Result pattern\n- Structured logging to stderr\n\n### 3. Fix P1 security issues\n- genOid(): Use std/sysrand or proper UUID\n- HeartbeatThread: Use ref type, not alloc0/dealloc\n\n### 4. Module reorganization (optional)\n- Move Message type to types.nim\n- Move query procs from state.nim to db.nim\n- All helpers to utils.nim\n\n## Success Criteria\n- No silent failures in error paths\n- taskId validated at CLI entry points\n- Common patterns extracted to utils.nim\n- P1 security bugs fixed\n- Compiler warnings resolved (unused imports)\n\n## Related Issues\nP1 bugs: skills-0wk, skills-xcl, skills-73yu, skills-bk7x\nError handling: skills-266, skills-8xv, skills-8vdo, skills-n6zf, skills-tdfm, skills-koes, skills-xgh0, skills-8bi, skills-2wjp, skills-3uv9\nExtraction: skills-3d9o, skills-dtk, skills-8fd, skills-dszn, skills-qiq0, skills-luzk, skills-5x2o, skills-r3k, skills-2xc, skills-f8yd, skills-y76g, skills-sisi\nValidation: skills-vuj2, skills-16zf\nDead code: skills-ghlb, skills-5ax, skills-kvdl, skills-ib9u, skills-fdu\nType safety: skills-audh, skills-0dxd","status":"open","priority":1,"issue_type":"epic","created_at":"2026-01-10T20:18:27.23875742-08:00","created_by":"dan","updated_at":"2026-01-10T20:18:27.23875742-08:00","dependencies":[{"issue_id":"skills-g2wa","depends_on_id":"skills-lzh2","type":"blocks","created_at":"2026-01-10T20:19:07.152899742-08:00","created_by":"dan"},{"issue_id":"skills-g2wa","depends_on_id":"skills-05ah","type":"blocks","created_at":"2026-01-10T20:19:07.191028704-08:00","created_by":"dan"},{"issue_id":"skills-g2wa","depends_on_id":"skills-69sz","type":"blocks","created_at":"2026-01-10T20:19:07.222958272-08:00","created_by":"dan"},{"issue_id":"skills-g2wa","depends_on_id":"skills-t9ub","type":"blocks","created_at":"2026-01-10T20:19:07.262832253-08:00","created_by":"dan"}]}
{"id":"skills-g2wa","title":"Architectural cleanup: error handling, validation, utilities","description":"# Architectural Cleanup Epic\n\nCode review of worker CLI scaffold revealed 44 issues that cluster into 5 systemic patterns.\nRather than fixing individually, address the underlying architecture.\n\n## Pattern Analysis\n\n| Pattern | Issues | % |\n|---------|--------|---|\n| Error handling gaps | 11 | 25% |\n| DRY / missing utilities | 12 | 27% |\n| Input validation missing | 4 | 9% |\n| Dead code | 5 | 11% |\n| Type safety | 3 | 7% |\n\n## Recommended Approach\n\n### 1. Create utils.nim module\nConsolidates 12 extraction issues:\n- branchName(taskId): string\n- worktreePath(taskId): string \n- msToUnix(ms: int64): int64\n- optField[T](row, idx): Option[T]\n- withTransaction template\n- validateTaskId(id): string\n\n### 2. Define error handling strategy\nTemplate for 11 error issues:\n- Wrap boundary operations (file I/O, git, DB) with context\n- Consistent exception types or Result pattern\n- Structured logging to stderr\n\n### 3. Fix P1 security issues\n- genOid(): Use std/sysrand or proper UUID\n- HeartbeatThread: Use ref type, not alloc0/dealloc\n\n### 4. Module reorganization (optional)\n- Move Message type to types.nim\n- Move query procs from state.nim to db.nim\n- All helpers to utils.nim\n\n## Success Criteria\n- No silent failures in error paths\n- taskId validated at CLI entry points\n- Common patterns extracted to utils.nim\n- P1 security bugs fixed\n- Compiler warnings resolved (unused imports)\n\n## Related Issues\nP1 bugs: skills-0wk, skills-xcl, skills-73yu, skills-bk7x\nError handling: skills-266, skills-8xv, skills-8vdo, skills-n6zf, skills-tdfm, skills-koes, skills-xgh0, skills-8bi, skills-2wjp, skills-3uv9\nExtraction: skills-3d9o, skills-dtk, skills-8fd, skills-dszn, skills-qiq0, skills-luzk, skills-5x2o, skills-r3k, skills-2xc, skills-f8yd, skills-y76g, skills-sisi\nValidation: skills-vuj2, skills-16zf\nDead code: skills-ghlb, skills-5ax, skills-kvdl, skills-ib9u, skills-fdu\nType safety: skills-audh, skills-0dxd","status":"closed","priority":1,"issue_type":"epic","created_at":"2026-01-10T20:18:27.23875742-08:00","created_by":"dan","updated_at":"2026-01-10T20:41:38.39788606-08:00","closed_at":"2026-01-10T20:41:38.39788606-08:00","close_reason":"All 4 sub-tasks completed: utils.nim, error handling, P1 security fixes, dead code cleanup","dependencies":[{"issue_id":"skills-g2wa","depends_on_id":"skills-lzh2","type":"blocks","created_at":"2026-01-10T20:19:07.152899742-08:00","created_by":"dan"},{"issue_id":"skills-g2wa","depends_on_id":"skills-05ah","type":"blocks","created_at":"2026-01-10T20:19:07.191028704-08:00","created_by":"dan"},{"issue_id":"skills-g2wa","depends_on_id":"skills-69sz","type":"blocks","created_at":"2026-01-10T20:19:07.222958272-08:00","created_by":"dan"},{"issue_id":"skills-g2wa","depends_on_id":"skills-t9ub","type":"blocks","created_at":"2026-01-10T20:19:07.262832253-08:00","created_by":"dan"}]}
{"id":"skills-gas","title":"spec-review: File discovery is brittle, can pick wrong file silently","description":"The fallback `find ... | head -1` is non-deterministic and can select wrong spec/plan/tasks file without user noticing. Branch names with `/` also break path construction.\n\nFixes:\n- Fail fast if expected file missing\n- Print chosen file path before proceeding\n- Require explicit confirmation if falling back\n- Handle branch names with slashes","status":"closed","priority":2,"issue_type":"bug","created_at":"2025-12-15T00:23:22.762045913-08:00","updated_at":"2025-12-15T00:46:16.231199231-08:00","closed_at":"2025-12-15T00:46:16.231199231-08:00"}
{"id":"skills-gga","title":"Configure Claude Code LSP integration","description":"Claude Code now has LSP (Language Server Protocol) integration that provides semantic code understanding.\n\n## Key Features\n- Go to Definition - Jump to symbol declarations\n- Find References - Locate all usages (safe refactoring) \n- Hover/Type Info - Get signatures, docstrings, types\n- Diagnostics - See compiler errors/warnings directly\n\n## Setup Required\n1. Enable via env var: ENABLE_LSP_TOOL=1\n2. Install language servers on PATH:\n - TypeScript: typescript-language-server\n - Python: pyright or python-lsp-server\n - Go: gopls\n - Rust: rust-analyzer\n - Nix: nil or nixd\n\n3. Optional: MCP adapter like cclsp for robust AI→LSP bridging\n\n## Tasks\n- [ ] Add language servers to Nix packages\n- [ ] Set ENABLE_LSP_TOOL=1 in shell environment\n- [ ] Test with representative projects\n- [ ] Consider creating an LSP skill documenting available servers\n\n## References\n- Discovered via orch consensus with sonar, flash-or, glm\n- Related to skills+molecules integration (semantic code understanding for traces)","status":"closed","priority":2,"issue_type":"feature","created_at":"2025-12-24T02:16:40.510669749-05:00","updated_at":"2025-12-24T23:33:58.635002347-05:00","closed_at":"2025-12-24T23:33:58.635002347-05:00","close_reason":"LSP servers deployed (gopls, pyright, typescript-language-server, rust-analyzer, nil, elixir-ls); ENABLE_LSP_TOOL=1 in sessionVariables; requires new session to test"}
{"id":"skills-ghlb","title":"Remove unused 'by' parameter from approve() or implement reviewer tracking","description":"[DEAD] MED worker.nim:121 - 'by' parameter declared but never used. Remove parameter, or implement reviewer tracking in state transition.","status":"closed","priority":2,"issue_type":"task","created_at":"2026-01-10T20:12:10.42538955-08:00","created_by":"dan","updated_at":"2026-01-10T20:41:09.698150063-08:00","closed_at":"2026-01-10T20:41:09.698150063-08:00","close_reason":"Dead code cleanup complete"}

2
.beads/last-touched
View file

@ -1 +1 @@
skills-5ax
skills-g2wa